Allowed to deactivate certificate validation #1254
Open
+824
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepitbull
force-pushed
the
feature/disable-cert-validation
branch
from
7146b85 to
a22f84d
Compare
caoccao
requested changes
Nov 4, 2025
| entry.getValue().stopAsync(true).get(); | ||
| } catch (final InterruptedException | ExecutionException e) { | ||
| log.error("Exception happened while shutting down adapter: ", e); | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Assuming an exception is thrown, the rest of protocol adapters are not stopped. Is this behavior expected?
| throw new RuntimeException(e); | ||
| } | ||
| }).get(connectionTimeoutSeconds, TimeUnit.SECONDS); | ||
| log.debug("OPC UA client connected successfully for adapter '{}'", adapterId); |
There was a problem hiding this comment.
This logging statement is in the right place? If client.connect() throws a UaException, a success will still be printed?
| quietlyCloseClient(client, false, faultListener, null); | ||
| return false; | ||
| } | ||
| } catch (final UaException e) { |
| * | ||
| * @return true if connection is healthy, false otherwise | ||
| */ | ||
| public boolean isHealthy() { |
There was a problem hiding this comment.
That's the one I expect! Nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #37845 and #37976
Changes